sslh: update to 2.3.1, add libproxyprotocol support

[meiser79]

See https://rutschle.net/tech/sslh/doc/proxyprotocol

📦 Package Details

Maintainer: @neheb

Description:
Add libproxysupport to sslh by adding the libproxysupport library and compile sslh against it.

🧪 Run Testing Details

• **OpenWrt Version: master
• OpenWrt Target/Subtarget:
• **OpenWrt Device: x86_64

---

✅ Formalities

• I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

[efahl]

@meiser79 Seems like this is three PRs all mashed into one. Might be easier to get reviews and commits if you did it in pieces:

• libproxyprotocol: add new package
• sslh: update to 2.3.0
• sslh: add proxyprotocol support

[efahl]

Ah, yes, that's much better. It shows that the patches are related to the version update and not the addition of proxyprotocol.

[meiser79]

libproxyprotocol file size:

root@openwrt:~# ll /usr/lib/libproxyprotocol.so 
-rwxr-xr-x    1 root     root         24578 Dec 22 12:52 /usr/lib/libproxyprotocol.so*

[efahl]

I'm guessing the formalities will fail on this due to no messages in the commits. And that size measurement would be a good tidbit to add to the message:

 libproxyprotocol: add new package 

Add new package to support blah blah blah

Resulting library size is
# ll /usr/lib/libproxyprotocol.so 
-rwxr-xr-x    1 root     root         24578 Dec 22 12:52 /usr/lib/libproxyprotocol.so*

Signed-off-by: ...

[meiser79]

@efahl, may I kindly ask to review again? Could it be merged?

[efahl]

The resulting code looks ok, but the commit history is problematic and needs to be squashed.

This should probably have just two commits: the first to add the new libproxyprotocol package, second one to extend sslh using it. Those intermediate ones that add and then remove patches just obfuscate what's going on.

[meiser79]

@efahl, thanks, cleanup done.

[efahl]

Looks good to me.