Skip to content

fail2ban,setools: remove python3-pkg-resources dependency#29056

Merged
commodo merged 2 commits intoopenwrt:masterfrom
commodo:fix-python3-pkg-resources
Apr 4, 2026
Merged

fail2ban,setools: remove python3-pkg-resources dependency#29056
commodo merged 2 commits intoopenwrt:masterfrom
commodo:fix-python3-pkg-resources

Conversation

@commodo
Copy link
Copy Markdown
Contributor

@commodo commodo commented Apr 3, 2026

📦 Package Details

*Maintainer: me, @flyn-org

Description:

Removed via commit 5f957ab


🧪 Run Testing Details

  • OpenWrt Version:
  • OpenWrt Target/Subtarget:
  • OpenWrt Device:

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable
    (e.g., subject line, commit description, etc.)
    We must try to upstream patches to reduce maintenance burden.

@commodo commodo changed the title Fix python3 pkg resources fail2ban,setools: remove python3-pkg-resources dependency Apr 3, 2026
commodo added 2 commits April 3, 2026 22:11
Fix dependency with python3-pkg-resources (it got removed).
And add test.sh

- Bump from 4.5.1 to 4.6.0
- Drop python3-pkg-resources dependency: setools uses
  'from importlib import resources as pkg_resources' which is stdlib,
  not the external pkg_resources package
- Update 010-no-gui.patch: pyproject.toml now manages script-files and
  package-data (was setup.py in 4.5.1); rewrite patch to target it
- Update 030-remove-host-paths.patch: lib_dirs now uses list[str] type
  hint; fix hunk header line numbers to match new upstream layout
- Add test.sh: verify core query classes (SELinuxPolicy, BoolQuery,
  TypeQuery, RoleQuery, UserQuery) are accessible

Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
The python3-pkg-resources package does not exist in OpenWrt.
The only distutils/setuptools usage in fail2ban 1.1.0 is in
filterpyinotify.py and filtersystemd.py, both of which are
optional backends not available on OpenWrt. They are loaded
lazily via ImportError-guarded calls and the default auto
backend falls through to polling without them.

Also add test.sh with basic import and CLI smoke test.

Add me as maintainer.

Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
@commodo commodo force-pushed the fix-python3-pkg-resources branch from e2cf098 to 36b9ab2 Compare April 3, 2026 19:12
@commodo commodo merged commit e850843 into openwrt:master Apr 4, 2026
12 checks passed
@commodo commodo deleted the fix-python3-pkg-resources branch April 4, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant