This repository was archived by the owner on Feb 25, 2020. It is now read-only.
Add support for fetching remote configuration #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Note this is on top of #34 )
Fixes #23
This allows defining per-project options in some central location. For convenience
PROJECT/MODULEexpands tohttps://openzipkin-contrib.github.io/apache-release-verification/presets/PROJECT/MODULE.yaml; that is, thegh-pagesbranch of this repo can serve as a central repository of configurations, but anyone is free to distribute their own configs however they like, as long as it's accessible over HTTP or HTTPS.As a proof of concept I've uploaded https://openzipkin-contrib.github.io/apache-release-verification/presets/zipkin/zipkin.yaml with the following contents:
That means one can now validate a Zipkin release as such:
The
--remote-configoption accepts full URLs as well, sozipkin/zipkinis equivalent tohttps://openzipkin-contrib.github.io/apache-release-verification/presets/zipkin/zipkin.yaml.Note that
--configand--remote-configcan appear together (and are resolved in the order they're provided on the command line, with the latter overriding values provided by the former). So this can also be written, given a localzipkin.yamlwith the keysversion,gpg-key, andgit-hash:A
remote-configfield in a local config file gets evaluated (but can be overridden via a command-line argument, like everything else specified via a local or remote config file)When
--remote-configis not passed in, we try to infer it asproject/module. Unlike explicitly defined--remote-configvalues, there is no error raised if this inferred remote config file doesn't exist.