Skip to content

Indicate error content type completely - #25030

Merged
NobodysNightmare merged 1 commit into
devfrom
fix-error-content-type
Sep 1, 2026
Merged

Indicate error content type completely#25030
NobodysNightmare merged 1 commit into
devfrom
fix-error-content-type

Conversation

@NobodysNightmare

Copy link
Copy Markdown
Contributor

Not sure why it was previously implemented as :json. No other occurence of error_representer uses
a short symbol.

Ticket

https://community.openproject.org/wp/AI-130

Not sure why it was previously implemented as :json.
No other occurence of .error_representer uses
a short symbol.
@NobodysNightmare
NobodysNightmare requested a review from a team August 31, 2026 14:27
@github-actions

Copy link
Copy Markdown

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]
  • rspec ./modules/gantt/spec/features/timeline/timeline_dates_spec.rb[1:3:2:3:1:1]
  • rspec ./spec/features/work_packages/table/queries/parent_field_ranking_spec.rb[1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #25030, linked for reference only):

- `rspec ./modules/backlogs/spec/features/inbox_column_spec.rb[1:7:1]`
- `rspec ./modules/gantt/spec/features/timeline/timeline_dates_spec.rb[1:3:2:3:1:1]`
- `rspec ./spec/features/work_packages/table/queries/parent_field_ranking_spec.rb[1:1]`

Treat this as a standalone task, unrelated to PR #25030. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #25030 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @NobodysNightmare to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @NobodysNightmare, and request a review from @NobodysNightmare.
On every commit, set @NobodysNightmare as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@NobodysNightmare
NobodysNightmare merged commit 6ea883b into dev Sep 1, 2026
13 checks passed
@NobodysNightmare
NobodysNightmare deleted the fix-error-content-type branch September 1, 2026 13:44
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants