Remove SCOUT_DRIVER=null addition to .env from orchid:install command #3071
+2
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addition used to help with setting up Orchid in earlier Laravel versions where scout driver was set to
algoliaby default. It could lead to errors since algolia was likely not installed.In current scout.php config https://github.com/laravel/scout/blob/10.x/config/scout.php it is set to
collectionwhich is an internal driver so we can remove setting SCOUT_DRIVER=null to .env and let users rely on what they have in scout.php by default.The PR does that. It removes the call adding the entry to .env, and it removes the setValueEnv() method too as it is private and isn't used anywhere else in InstallCommand class.