Skip to content

Conversation

@graker
Copy link
Contributor

@graker graker commented Dec 16, 2025

The addition used to help with setting up Orchid in earlier Laravel versions where scout driver was set to algolia by default. It could lead to errors since algolia was likely not installed.

In current scout.php config https://github.com/laravel/scout/blob/10.x/config/scout.php it is set to collection which is an internal driver so we can remove setting SCOUT_DRIVER=null to .env and let users rely on what they have in scout.php by default.

The PR does that. It removes the call adding the entry to .env, and it removes the setValueEnv() method too as it is private and isn't used anywhere else in InstallCommand class.

…, remove setValueEnv() method from the same command as it is not used anywhere else
@tabuna
Copy link
Member

tabuna commented Dec 17, 2025

I think this is a good and correct decision, and I’m glad we no longer need this workaround.
However, the default driver was switched to collection only starting from version v10.19.1.

To avoid potential conflicts, it would be great to explicitly reflect this in composer.json by adding:

"conflict": {
    "laravel/scout": "<10.19.1"
}

It also makes sense to completely remove this dependency for the 9.x branch.

Added conflict with earlier versions of laravel scout
@graker
Copy link
Contributor Author

graker commented Dec 17, 2025

To avoid potential conflicts, it would be great to explicitly reflect this in composer.json by adding

Done. Though I'm not so sure if it's needed: if someone installs Orchid and doesn't have laravel/scout already, they will probably get the latest version (unless other restrictions of course). And if they do have scout, they likely have it already configured and not updating .env won't break anything for them. At the same time, the only reason to require 10.19.1 is that scout driver won't be set to null instead of algolia and other than that the package should be perfectly functional with scout 9 or 10. But maybe I just don't see the full picture.

It also makes sense to completely remove this dependency for the 9.x branch.

I don't think I understand, what to remove for the 9.x branch? 9.x of scout?

@tabuna tabuna merged commit 39bf1b6 into orchidsoftware:master Dec 17, 2025
38 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants