Conversation
|
@andersevenrud could you give this a look at some point? As far as I remember it's complete, I know it's been quite a while. The linter is failing due to the commits being made before Conventional Commits were enforced, so on merge we can just squash and use an appropriate message to satisfy that requirement. |
| pid: options.pid | ||
| }; | ||
|
|
||
| let target = args[0]; |
There was a problem hiding this comment.
Not really sure if this belongs in this PR 🤔
| } | ||
| } else if (method === 'archive') { | ||
| const [selection] = args; | ||
| const mount = this.getMountpointFromPath(selection[0].path); |
There was a problem hiding this comment.
This will throw an exception if somehow an empty selection is supplied 🤔
Probably best to handle this.
Also, this condition can be removed and the stuff below can be changed to (excluding this check):
const [input] = args;
const file = method === 'archive' ? input[0].path : input;
const mount = this.getMountpointFromPath(file);
if (!mount) {
throw new Error('Failed to resolve mountpoint');
}
return VFS[method](mount._adapter, mount)(...args);| @@ -2197,20 +2197,21 @@ export type FilesystemMountpoint = { | |||
| * Filesystem Adapter Methods | |||
There was a problem hiding this comment.
Gah. I can't see if these are tabs or note here. But wasn't this fixed in another commit ?
2 participants
Paired with os-js/osjs-server#64, this PR is meant to enable the use of archive functionality for the file manager application. Closes out #184 when merged, and will make progress towards closing out os-js/osjs-filemanager-application#39.
Closes #184