Add support for running run, artifacts, and archive subcommands without a fuzzing harness - #356
Conversation
b25f646 to
28852ee
Compare
|
Note: the sanitizer and architecture fields in crs.yaml don't have as much meaning without a target harness but are still required |
azchin
left a comment
azchin
left a comment
There was a problem hiding this comment.
Thanks, please refer to the comments
| if not (self.repo_path / ".git").exists(): | ||
| self.repo_hash = hashlib.sha256( | ||
| str(self.repo_path.resolve()).encode() | ||
| ).hexdigest()[:12] | ||
| return self.repo_hash |
There was a problem hiding this comment.
Can you hash the directory contents instead of the path name? Something like a digest over file paths + sizes + mtimes
There was a problem hiding this comment.
I'll just remove this change for now, originally it was to try to get a more stable repo hash for the artifacts/archive subcommands
There was a problem hiding this comment.
I think the main reason I wanted to avoid hashing the contents was that if the source directory was changed it would be hard to find artifacts from previous runs, but I can update it.
fee07f0 to
b36ad31
Compare
|
Looks good! LMK if there's anything else you want to add, otherwise I'll go ahead and merge |
|
Reviewing again, the other thing was whether the sanitizers/architecture in crs.yaml should still be required for auditing CRSs, but removing the check might not be worth it |
|
Recent changes: updated docs, made sanitizer/architecture optional with default being to support all sanitizers/architectures to match fuzzing engine default, did not include sanitizer, fuzzing_language, and architecture environment variables for source-only runs, added target key for source-only runs based on a hash of the source path to support non-git repositories. |
ada068c to
7a980be
Compare
… without fuzzing harness Signed-off-by: Brandon Luo <br32710@ll.mit.edu>
azchin
left a comment
azchin
left a comment
There was a problem hiding this comment.
Documentation and nitpicks
…only mode Signed-off-by: Brandon Luo <br32710@ll.mit.edu>
|
Updated documentation and removed unneeded environment variables |
2 participants
Summary
Describe what changed and why.
archive --allincludes exchange dirs, run logs, and shared dirs even if no harness is specifiedUser Impact
If user-facing, describe CLI/API/config/docs impact and migration steps.
Added note about source-only CRSs in crs-development.md
Release Note / Changelog
CHANGELOG.md([Unreleased]) for user-facing changesIf this PR includes deprecation or breaking behavior, include:
Validation
List tests/checks run and their results.
Checklist