ci: Sync Rust linting checks from bootc-dev/bootc#3577
Merged
cgwalters merged 6 commits intoostreedev:mainfrom Mar 31, 2026
Merged
ci: Sync Rust linting checks from bootc-dev/bootc#3577cgwalters merged 6 commits intoostreedev:mainfrom
cgwalters merged 6 commits intoostreedev:mainfrom
Conversation
The existing cargo fmt check only covered the ostree workspace package. Add fmt checks for the standalone test crates (tests/inst, tests/bootc-integration, tests/xtask) which are separate workspaces. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
Align with bootc's validate target: - Make cargo clippy gating (was "non-gating") with the same lint config as bootc (-A clippy::all -D clippy::correctness -D clippy::suspicious -Dunused_imports -Ddead_code) - Extend clippy to cover test crates (tests/inst, tests/bootc-integration, tests/xtask) - Add cargo doc with -D warnings to catch rustdoc issues Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Skipping CI for Draft Pull Request. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
These structs were never constructed, flagged by cargo clippy with -Ddead_code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
Add just targets mirroring the CI Rust checks so developers can run them locally before pushing: - validate: runs both fmt and clippy checks - cargo-fmt-check: checks formatting across all crates - cargo-clippy: runs clippy with the same lint config as CI Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
…eature - Replace inline cargo fmt/clippy commands in rust.yml with just cargo-fmt-check and just cargo-clippy for consistency with local dev - Make Justfile cargo-clippy use CARGO_PROJECT_FEATURES env var (defaults to v2022_6) so CI and local use share the same config - Add missing v2024_7 feature to Cargo.toml to fix cargo doc failure caused by unexpected cfg condition Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Xiaofeng Wang <henrywangxf@me.com>
github-actions
bot
added
the
area/rust-bindings
henrywang
changed the title
cgwalters
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmtandcargo clippychecks to cover all Rust crates (tests/inst,tests/bootc-integration,tests/xtask), not just theostreeworkspace-D clippy::correctness -D clippy::suspicious -Dunused_imports -Ddead_codecargo docwith-D warningsto catch rustdoc issuesjust validate,just cargo-fmt-check, andjust cargo-clippytargets for local developmenttests/xtask, dead code intests/inst, missingv2024_7feature inCargo.toml, and broken intra-doc links inrust-bindings/src/repo.rs