removed deprecated expo variables. fixes #23#31
Open
rabbihossain wants to merge 1 commit intoovr:masterfrom
Open
removed deprecated expo variables. fixes #23#31rabbihossain wants to merge 1 commit intoovr:masterfrom
rabbihossain wants to merge 1 commit intoovr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getExpoRoot and isExpo are not being in used in this library. Also these expo variables are deprecated anyway. I also don't think that the exported isExpo function in relevant to this library. (isExpo in not even documented on this library's documentation too.)
Since no one addressing this issue or fixing it. I think I'll leave the PR here. Rest is up to the maintainer. :)