fix(collaboration): [OCISDEV-781] return 200 OK for WOPI Lock in read-only and view-only modes#12257
Merged
kobergj merged 1 commit intoowncloud:masterfrom Apr 24, 2026
Conversation
kobergj
force-pushed
the
feat/OCISDEV-781-wopi-lock-read-only
branch
2 times, most recently
from
476aacb to
a550b39
Compare
mzner
approved these changes
Apr 23, 2026
2403905
approved these changes
Apr 23, 2026
kobergj
force-pushed
the
feat/OCISDEV-781-wopi-lock-read-only
branch
from
a550b39 to
58cb9c5
Compare
kobergj
force-pushed
the
feat/OCISDEV-781-wopi-lock-read-only
branch
from
58cb9c5 to
bd9635c
Compare
…-only modes OnlyOffice sends a WOPI Lock request on document open regardless of whether the user has write access. The Lock handler was calling SetLock with a read-only CS3 token, which returned a permission error propagated as HTTP 500 to OnlyOffice, causing an error dialog on load. Return 200 OK immediately for READ_ONLY and VIEW_ONLY view modes without acquiring a CS3 lock. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Julian Koberg <julian.koberg@kiteworks.com>
kobergj
force-pushed
the
feat/OCISDEV-781-wopi-lock-read-only
branch
from
bd9635c to
8e8041a
Compare
2403905
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetLockwith a read-only CS3 token, which returned a permission error propagated as HTTP 500 to OnlyOffice, causing an error dialog on load200 OKimmediately forREAD_ONLYandVIEW_ONLYview modes without acquiring a CS3 lockRoot cause
In oCIS 8.0.0 a role permission fix correctly removed
InitiateFileUploadfrom Viewer roles. As a result, viewer users now correctly receiveViewMode=READ_ONLYinstead ofREAD_WRITE. OnlyOffice always sends a Lock request on open even whenUserCanWrite=false. The WOPI Lock handler did not check the view mode before callingSetLock, causing a CS3 permission error → HTTP 500 → OnlyOffice error dialog. Before 8.0.0 this was hidden because viewers were incorrectly treated as editors.Test plan
.docx/.xlsx/.pdffile via a read-only share in OnlyOffice — no error dialog should appear and the file opens in view modemake -C services/collaboration testCloses OCISDEV-781
🤖 Generated with Claude Code