Conversation
- Add persistent volumes for grafana_data and prometheus_data - Create Grafana provisioning configuration for automatic Prometheus datasource - Add dashboard provisioning setup with proper directory structure - Eliminate need to manually configure Grafana-Prometheus connection - Data now persists across container restarts (API keys, metrics, dashboards) - Grafana automatically connects to Prometheus on startup Key files: - grafana/provisioning/datasources/prometheus.yml: Auto-configures Prometheus datasource - grafana/provisioning/dashboards/dashboard.yml: Dashboard provisioning config - Updated docker-compose.yml with persistent volumes and volume mounts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds persistent storage for Prometheus and Grafana and automates Grafana provisioning of the Prometheus datasource and dashboards.
- Introduce Grafana datasource config for Prometheus
- Add dashboard provisioning provider configuration
- Update
docker-compose.ymlto mount persistent volumes and provisioning directories
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| grafana/provisioning/datasources/prometheus.yml | Auto-configures Prometheus as a Grafana datasource |
| grafana/provisioning/dashboards/dashboard.yml | Defines a dashboard provider pointing at the mounted dashboards |
| docker-compose.yml | Adds prometheus_data volume and mounts provisioning paths |
Comments suppressed due to low confidence (2)
docker-compose.yml:46
- There is trailing whitespace at the end of this mount line, which can cause YAML parsing errors. Please remove the extra spaces.
- ./grafana/provisioning/dashboards:/etc/grafana/provisioning/dashboards
docker-compose.yml:47
- Ensure that the
./grafana/dashboardsdirectory exists in the repo and contains dashboard JSON files or placeholders; otherwise Grafana provisioning will find an empty directory.
- ./grafana/dashboards:/var/lib/grafana/dashboards
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key files: