Skip to content

Bodhi updates fixes#3090

Merged
centosinfra-prod-github-app[bot] merged 2 commits intopackit:mainfrom
lbarcziova:bodhi-updates-fixes
Apr 1, 2026
Merged

Bodhi updates fixes#3090
centosinfra-prod-github-app[bot] merged 2 commits intopackit:mainfrom
lbarcziova:bodhi-updates-fixes

Conversation

@lbarcziova
Copy link
Copy Markdown
Member

No description provided.

From 5 retries to 8, to handle better transient errors/race conditions.
This should result in ~13 min retry window instead of ~1.5 (after 3s, 6, 12, 24, 48, 96, 192, 384).
@lbarcziova lbarcziova requested a review from a team as a code owner April 1, 2026 12:58
@lbarcziova lbarcziova requested review from majamassarini and removed request for a team April 1, 2026 12:58
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the maximum retries for Bodhi tasks to 8 and integrates Sentry error reporting when those retries are exhausted. Feedback was provided regarding the placement of the Sentry reporting call inside a loop, which could lead to redundant reports for a single task. Additionally, there is a risk that the worker could crash due to a missing Sentry SDK dependency, potentially masking the original exception and preventing further error-handling logic from executing.

@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

@lbarcziova lbarcziova added the mergeit Merge via Zuul label Apr 1, 2026
@centosinfra-prod-github-app
Copy link
Copy Markdown
Contributor

@centosinfra-prod-github-app centosinfra-prod-github-app bot merged commit 5e38698 into packit:main Apr 1, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Packit pull requests Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

Development

Successfully merging this pull request may close these issues.

3 participants