Skip to content

chore: replace taplo with tombi#1557

Merged
JP-Ellis merged 1 commit intomainfrom
chore/replace-taplo-with-tombi
Apr 16, 2026
Merged

chore: replace taplo with tombi#1557
JP-Ellis merged 1 commit intomainfrom
chore/replace-taplo-with-tombi

Conversation

@JP-Ellis
Copy link
Copy Markdown
Contributor

📝 Summary

Switching from Tapl to Tombi, and cleaning up the TOML files while I'm at it.

🚨 Breaking Changes

🔥 Motivation

Taplo's maintainer has gone on an indefinite break.

🔨 Test Plan

🔗 Related issues/PRs

@JP-Ellis JP-Ellis self-assigned this Apr 16, 2026
Copilot AI review requested due to automatic review settings April 16, 2026 04:25
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74%. Comparing base (3e6a602) to head (6718094).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1557   +/-   ##
====================================
  Coverage    74%     74%           
====================================
  Files        36      36           
  Lines      3993    3993           
====================================
  Hits       2976    2976           
  Misses     1017    1017           
Flag Coverage Δ
examples 37% <ø> (ø)
tests 73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The maintainer for taplo has gone on an indefinite break, so switching
to tombi for TOML formatting and linting.

This is also an opportunity to implement a few changes to the hatch
config:

- pypa/hatch#1852
- pypa/hatch#1639

Signed-off-by: JP-Ellis <josh@jpellis.me>
@JP-Ellis JP-Ellis force-pushed the chore/replace-taplo-with-tombi branch from 1bded08 to 6718094 Compare April 16, 2026 04:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR switches the repository’s TOML formatting/linting tooling from Taplo to Tombi and reformats/normalizes various TOML/pyproject configurations accordingly.

Changes:

  • Replace Taplo configuration with Tombi configuration and add Tombi format/lint hooks to pre-commit.
  • Reformat and reorganize pyproject.toml files (root + subprojects) and Ruff config TOMLs for consistent formatting.
  • Update editor recommendations to prefer the Tombi VS Code extension.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/.ruff.toml TOML formatting normalization for Ruff config.
pyproject.toml Large TOML reformat + restructured tool tables (Hatch/Coverage/Pytest/Ruff/Typos).
pact-python-ffi/tests/.ruff.toml TOML formatting normalization for Ruff config.
pact-python-ffi/pyproject.toml Large TOML reformat + restructured tool tables (build/test tooling).
pact-python-cli/pyproject.toml Large TOML reformat + restructured tool tables (build/test tooling).
examples/http/xml_example/pyproject.toml TOML reformat + tool table restructuring.
examples/http/service_consumer_provider/pyproject.toml TOML reformat + tool table restructuring.
examples/http/requests_and_fastapi/pyproject.toml TOML reformat + tool table restructuring.
examples/http/aiohttp_and_flask/pyproject.toml TOML reformat + tool table restructuring.
examples/catalog/pyproject.toml TOML reformat + tool table restructuring.
docs/scripts/.ruff.toml TOML formatting normalization for Ruff config.
committed.toml TOML formatting normalization.
.vscode/extensions.json Replace TOML extension recommendation with Tombi.
.tombi.toml Add Tombi formatter configuration.
.taplo.toml Remove Taplo configuration.
.pre-commit-config.yaml Add Tombi pre-commit hooks (format + lint).

Comment thread pyproject.toml
Comment thread pyproject.toml
Comment thread pact-python-cli/pyproject.toml
Comment thread pact-python-ffi/pyproject.toml
Comment thread pact-python-ffi/pyproject.toml
@JP-Ellis JP-Ellis merged commit 04032c5 into main Apr 16, 2026
41 checks passed
@JP-Ellis JP-Ellis deleted the chore/replace-taplo-with-tombi branch April 16, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants