Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1557 +/- ##
====================================
Coverage 74% 74%
====================================
Files 36 36
Lines 3993 3993
====================================
Hits 2976 2976
Misses 1017 1017
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The maintainer for taplo has gone on an indefinite break, so switching to tombi for TOML formatting and linting. This is also an opportunity to implement a few changes to the hatch config: - pypa/hatch#1852 - pypa/hatch#1639 Signed-off-by: JP-Ellis <josh@jpellis.me>
1bded08 to
6718094
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR switches the repository’s TOML formatting/linting tooling from Taplo to Tombi and reformats/normalizes various TOML/pyproject configurations accordingly.
Changes:
- Replace Taplo configuration with Tombi configuration and add Tombi format/lint hooks to pre-commit.
- Reformat and reorganize
pyproject.tomlfiles (root + subprojects) and Ruff config TOMLs for consistent formatting. - Update editor recommendations to prefer the Tombi VS Code extension.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/.ruff.toml | TOML formatting normalization for Ruff config. |
| pyproject.toml | Large TOML reformat + restructured tool tables (Hatch/Coverage/Pytest/Ruff/Typos). |
| pact-python-ffi/tests/.ruff.toml | TOML formatting normalization for Ruff config. |
| pact-python-ffi/pyproject.toml | Large TOML reformat + restructured tool tables (build/test tooling). |
| pact-python-cli/pyproject.toml | Large TOML reformat + restructured tool tables (build/test tooling). |
| examples/http/xml_example/pyproject.toml | TOML reformat + tool table restructuring. |
| examples/http/service_consumer_provider/pyproject.toml | TOML reformat + tool table restructuring. |
| examples/http/requests_and_fastapi/pyproject.toml | TOML reformat + tool table restructuring. |
| examples/http/aiohttp_and_flask/pyproject.toml | TOML reformat + tool table restructuring. |
| examples/catalog/pyproject.toml | TOML reformat + tool table restructuring. |
| docs/scripts/.ruff.toml | TOML formatting normalization for Ruff config. |
| committed.toml | TOML formatting normalization. |
| .vscode/extensions.json | Replace TOML extension recommendation with Tombi. |
| .tombi.toml | Add Tombi formatter configuration. |
| .taplo.toml | Remove Taplo configuration. |
| .pre-commit-config.yaml | Add Tombi pre-commit hooks (format + lint). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Switching from Tapl to Tombi, and cleaning up the TOML files while I'm at it.
🚨 Breaking Changes🔥 Motivation
Taplo's maintainer has gone on an indefinite break.
🔨 Test Plan
🔗 Related issues/PRs