Fix remove_constant to stop removing constants that are already remove_constanted but not GCed#2200
Closed
genkami wants to merge 2 commits intopadrino:masterfrom
Closed
Fix remove_constant to stop removing constants that are already remove_constanted but not GCed#2200genkami wants to merge 2 commits intopadrino:masterfrom
genkami wants to merge 2 commits intopadrino:masterfrom
Conversation
Contributor
|
@genkami Could you provide an example for reproducing the error? |
Contributor
Author
|
I added a test case that reproduces the errror. It fails without 8542c62. This is how this error occurs:
|
e68a909 to
ab8dded
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a bug with
remove_constantand GC.I wll later give an example that potentially causes this bug.