Conversation
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
soixdev91
marked this pull request as ready for review
July 15, 2026 15:31
soixdev91
requested review from
a team,
Leerti,
emilio-dimari and
gispada
as code owners
July 15, 2026 15:31
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8306 +/- ##
=======================================
Coverage 62.91% 62.92%
=======================================
Files 1963 1963
Lines 37267 37272 +5
Branches 6284 6287 +3
=======================================
+ Hits 23447 23453 +6
Misses 12436 12436
+ Partials 1384 1383 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
In this PR
watchFciSignatureRequestRetrySagahas been improved so that a user getting an error even when he successfully sign ( for example doubled signature request, the first request with 200 status code not received by the app and a second one with error leading to a retry caused by an already signed request) now before retry we check the signature status.List of changes proposed in this pull request
watchFciSignatureRequestRetrySaganow checks the status (and expiry) of the freshly fetched signature request before deciding what to doHow to test
Start the app with the dev server and proxyman ready, start a FCI flow with a pending request and at the start of the flow take the */api/sign/v1/signature-requests/* raw response aside for later, then in the app get to the last step of the signing flow and just before completing the request:
Set on Proxyman the following "Map Local" rule:
*/api/sign/v1/signatures
HTTP/1.1 400 Bad RequestThen press on the app the sign button ( which will lead to retry screen
FCI_TYP), and again on Proxyman set:*/api/sign/v1/signature-requests/*
(paste the previously saved response changing only
status":"WAIT_FOR_SIGNATURE"tostatus":"SIGNED")HTTP/1.1 200 OK....Now the app should redirect the user to the signature completed screen.
FCI.mov
Registrazione.schermo.2026-07-08.alle.14.58.20.mov