Skip to content

chore: [IEL-684] FCI - retry checks for signature request status#8306

Open
soixdev91 wants to merge 8 commits into
masterfrom
IEL-684
Open

chore: [IEL-684] FCI - retry checks for signature request status#8306
soixdev91 wants to merge 8 commits into
masterfrom
IEL-684

Conversation

@soixdev91

Copy link
Copy Markdown
Collaborator

Short description

In this PR watchFciSignatureRequestRetrySaga has been improved so that a user getting an error even when he successfully sign ( for example doubled signature request, the first request with 200 status code not received by the app and a second one with error leading to a retry caused by an already signed request) now before retry we check the signature status.

List of changes proposed in this pull request

  • watchFciSignatureRequestRetrySaga now checks the status (and expiry) of the freshly fetched signature request before deciding what to do

How to test

Start the app with the dev server and proxyman ready, start a FCI flow with a pending request and at the start of the flow take the */api/sign/v1/signature-requests/* raw response aside for later, then in the app get to the last step of the signing flow and just before completing the request:
Set on Proxyman the following "Map Local" rule:
*/api/sign/v1/signatures
HTTP/1.1 400 Bad Request
Then press on the app the sign button ( which will lead to retry screen FCI_TYP), and again on Proxyman set:
*/api/sign/v1/signature-requests/*
(paste the previously saved response changing only status":"WAIT_FOR_SIGNATURE" to status":"SIGNED")HTTP/1.1 200 OK....
Now the app should redirect the user to the signature completed screen.

BeforeAfter
FCI.mov
Registrazione.schermo.2026-07-08.alle.14.58.20.mov

@github-actions

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@soixdev91 soixdev91 self-assigned this Jul 15, 2026
@soixdev91
soixdev91 requested a review from Ladirico July 15, 2026 15:18
@soixdev91
soixdev91 marked this pull request as ready for review July 15, 2026 15:31
@soixdev91
soixdev91 requested review from a team, Leerti, emilio-dimari and gispada as code owners July 15, 2026 15:31
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.92%. Comparing base (2ce0d5d) to head (6a0a12d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8306   +/-   ##
=======================================
  Coverage   62.91%   62.92%           
=======================================
  Files        1963     1963           
  Lines       37267    37272    +5     
  Branches     6284     6287    +3     
=======================================
+ Hits        23447    23453    +6     
  Misses      12436    12436           
+ Partials     1384     1383    -1     
Files with missing lines Coverage Δ
apps/main-app/ts/features/fci/saga/index.ts 61.17% <100.00%> (+2.42%) ⬆️
...in-app/ts/features/fci/screens/FciRouterScreen.tsx 63.41% <100.00%> (+2.43%) ⬆️
...ps/main-app/ts/features/fci/store/actions/index.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ce0d5d...6a0a12d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant