[Components] Fix function columns by composing wire object set by ziyunp · Pull Request #2955 · palantir/osdk-ts

ziyunp · 2026-04-07T15:12:03Z

Fixing regression on function columns after useObjectSet and useOsdkObjects is fixed to return the rich object set only when loading is false. The function query expects wire object set and not the rich object set.

Error:

Expected param:

{
  "employees": {
    "type": "filter",
    "objectSet": {
      "type": "filter",
      "objectSet": {
        "type": "base",
        "objectType": "Employee"
      },
      "where": {
        "type": "eq",
        "field": "employeeNumber",
        "value": 657495071
      }
    },
  }
}

github-actions · 2026-04-07T15:13:55Z

size-limit report 📦

Path	Size	Change
`@osdk/api`	432 B	0%
`@osdk/client`	24.11 kB	0%
`@osdk/oauth`	6.52 kB	0%
`@osdk/react`	513 B	0%
`@osdk/react/experimental`	50.08 kB	+2.31% 🔺
`@osdk/react/experimental/admin`	2.43 kB	0%
`@osdk/react-components`	10 B	0%
`@osdk/react-components/experimental`	320.01 kB	+0.55% 🔺
`@osdk/react-components/primitives`	40.33 kB	0%
`@osdk/widget.client-react`	10.56 kB	0%

ziyunp · 2026-04-07T15:25:42Z

packages/react-components/src/object-table/hooks/useObjectTableData.ts

  const baseResult = shouldUseObjectSet ? objectSetResult : osdkObjectsResult;

+  // Omitting withProperties as it causes an error when present in the function param
+  const wireObjectSet = useMemo(() => {


@KuberSethi An option is to compose the wireObjectSet here and remove the wireObjectSet from the hooks return values.

I will need to do this anyway because the function query fails when there are derived properties in the object set param.

because the function query fails when there are derived properties in the object set param.

Why is this failing / could you share more details?

I believe it's a function api issue. I raised this with the functions team

KuberSethi

initial comments - lots of minor things (typing can be tightened in a lot of places) but I want to index on directionality first. I think it's possible to do this internally without changing our contracts but let me know if you disagree.

took an initial (very LLM driven) approach to illustrate, again ignore any specific errors lets just lock down directionality rn #2957

KuberSethi · 2026-04-07T17:39:15Z

packages/react-components/src/object-table/hooks/useFunctionColumnsData.ts

  // eslint-disable-next-line react-hooks/exhaustive-deps
-  const stableObjectSet = useMemo(() => objectSet, [JSON.stringify(objectSet)]);
+  const stableObjectSet = useMemo(() => wireObjectSet, [
+    // eslint-disable-next-line react-hooks/exhaustive-deps


Here and above why do we have this eslint disable? Maybe I'm missing something but there's nothing about this usecase that would require this imo, surely we can get rid of it and rearchitect things to where its not necessary?

It's just a nit where I suppress the warning for the wireObjectSet dependency that I intentionally leave out to return a stable object set based on their stringified value.

KuberSethi · 2026-04-07T17:40:42Z

packages/react-components/src/object-table/hooks/useObjectTableData.ts

  const baseResult = shouldUseObjectSet ? objectSetResult : osdkObjectsResult;

+  // Omitting withProperties as it causes an error when present in the function param
+  const wireObjectSet = useMemo(() => {


because the function query fails when there are derived properties in the object set param.

Why is this failing / could you share more details?

KuberSethi · 2026-04-07T17:42:10Z

packages/react/src/new/hookUtils.ts

+ * Composes a base ObjectSet with hook options and returns the wire
+ * representation. Available immediately — does not depend on loading state.
+ */
+export function composeWireObjectSet(


I think this is identical to ObjectSetQuery.composeObjectSet()? Any chance of reuse or nah?

We we will need to make #composeObjectSet a static function and use it here. I can do that if you have no problem making it a static method of ObjectSetQuery class

Hmm.. ObjectSetQuery is in @osdk/client and to do this we will need to export ObjectSetQuery from client. I'd prefer to duplicate the logic than to export that class in @osdk/client. What do u think?

KuberSethi · 2026-04-07T17:42:54Z

packages/react/src/new/useOsdkObjects.ts

+   * The wire representation of the final ObjectSet after all transformations.
+   * Available immediately without waiting for loading to complete.
+   */
+  wireObjectSet: ReturnType<typeof getWireObjectSet> | undefined;


hmm I think this is really confusing to users, especially to LLMs, do we need to expose this or is there a way to make this internal?

Yeah so I was considering to only export composeWireObjectSet function, and compose it within the useObjectTableData hook

nfdiop · 2026-04-08T11:51:51Z

packages/react-components/src/object-table/hooks/useFunctionColumnsData.ts

          queryDefinition: config.queryDefinition,
          options: {
-            params: config.getParams(stableObjectSet),
+            params: config.getParams(composedObjectSet!),


can we drop ! by dropping the intermediate stableObjectSet?

nfdiop · 2026-04-08T12:02:28Z

packages/react/src/public/experimental.ts

 * limitations under the License.
 */

+export { composeObjectSet } from "../new/composeObjectSet.js";


should we export this?

nfdiop · 2026-04-08T12:03:00Z

packages/react/src/new/composeObjectSet.ts

+ *
+ * This is a copy of ObjectSetQuery.#composeObjectSet in @osdk/client
+ */
+export function composeObjectSet<


suggestion (not-blocking): could we add a TODO to reuse the one from @osdk/client?

nfdiop · 2026-04-08T12:07:35Z

packages/react/src/new/composeObjectSet.ts

+      RDPs
+    >;
+  }
+  if (options.where) {


question (blocking): how are we using the filter passed through the objectsTableApi?

nfdiop · 2026-04-08T12:09:39Z

packages/react/src/new/composeObjectSet.ts

+  let result: ObjectSet<Q, RDPs> = baseObjectSet;
+
+  if (options.withProperties) {
+    result = result.withProperties(options.withProperties) as ObjectSet<


I may be missing something but I thought we wanted to drop this?

ziyunp · 2026-04-08T13:01:03Z

Closing this PR with fixes in the new PR: #2967

Return wireObjectSet

dce8e69

ziyunp changed the title ~~Return wireObjectSet~~ Return wireObjectSet in useOsdkObjects and useObjectSet Apr 7, 2026

Compose wireObjectSet

26c64d4

ziyunp commented Apr 7, 2026

View reviewed changes

KuberSethi reviewed Apr 7, 2026

View reviewed changes

ziyunp changed the title ~~Return wireObjectSet in useOsdkObjects and useObjectSet~~ Fix function columns by composing wire object set Apr 7, 2026

ziyunp force-pushed the zpoh/fix-func branch from eea2ab5 to 0b07872 Compare April 7, 2026 18:22

Revert changes to react hooks

5c5c05a

ziyunp force-pushed the zpoh/fix-func branch from 0b07872 to 5c5c05a Compare April 7, 2026 18:23

ziyunp added 2 commits April 8, 2026 11:20

Fix checks

b33f3c9

Fix types

75bc963

ziyunp changed the title ~~Fix function columns by composing wire object set~~ [Components] Fix function columns by composing wire object set Apr 8, 2026

nfdiop reviewed Apr 8, 2026

View reviewed changes

ziyunp closed this Apr 8, 2026

Conversation

ziyunp commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

ziyunp Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KuberSethi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ziyunp Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ziyunp commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ziyunp commented Apr 7, 2026 •

edited

Loading

github-actions bot commented Apr 7, 2026 •

edited

Loading

ziyunp Apr 7, 2026 •

edited

Loading

ziyunp Apr 7, 2026 •

edited

Loading