fix: show full argument in error for unknown short option#3236
Closed
thakoreh wants to merge 1 commit intopallets:mainfrom
Closed
fix: show full argument in error for unknown short option#3236thakoreh wants to merge 1 commit intopallets:mainfrom
thakoreh wants to merge 1 commit intopallets:mainfrom
Conversation
When processing short options character by character, if an unknown option is encountered, the error message now shows the full argument (e.g., '-dbgwrong') instead of just the first unknown character (e.g., '-w' or '-d'). Fixes pallets#2779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2779
When processing short options character by character, if an unknown option is encountered, the error message now shows the full argument (e.g.,
-dbgwrong) instead of just the first unknown character (e.g.,-d).Before
After
Changes
raise NoSuchOption(opt, ctx=self.ctx)toraise NoSuchOption(arg, ctx=self.ctx)in_match_short_optThis provides more context when the user makes a typo in a multi-character short option.