Fix #2779: Show full option name in error for multicharacter short options#3303
Closed
717986230 wants to merge 2 commits intopallets:mainfrom
Closed
Fix #2779: Show full option name in error for multicharacter short options#3303717986230 wants to merge 2 commits intopallets:mainfrom
717986230 wants to merge 2 commits intopallets:mainfrom
Conversation
…hort options When passing a wrong multicharacter short option like `-dbgwrong`, the error message incorrectly shows 'No such option: -d' instead of the full option name. This fix reports the full original argument when raising NoSuchOption, instead of just the first invalid character. Fixes pallets#2779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2779
Problem
When passing a wrong multicharacter short option like
-dbgwrong, the error message incorrectly shows:instead of the full option name:
Root Cause
In
_match_short_opt(), the function iterates through each character of the argument and raisesNoSuchOptionwith just the first invalid character, not the original argument.Solution
Modified
src/click/parser.pyto report the full original argument when raisingNoSuchOption:Testing
Impact
This PR was created with AI assistance. The fix is minimal and focused on the reported issue.