Fix launch() with locate=True for paths containing spaces on Windows#3307
Closed
Bahtya wants to merge 1 commit intopallets:mainfrom
Closed
Fix launch() with locate=True for paths containing spaces on Windows#3307Bahtya wants to merge 1 commit intopallets:mainfrom
Bahtya wants to merge 1 commit intopallets:mainfrom
Conversation
When path contains spaces, Windows Explorer misinterprets the /select argument. Wrap the path in double quotes so Explorer handles it correctly. Fixes pallets#2994
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows,
click.launch(path, locate=True)builds the command:When the path contains spaces, Windows Explorer misinterprets it and opens the wrong location or fails silently.
Solution
Wrap the path in double quotes:
Previous attempt in #3216 was closed without merging.
Fixes #2994