Skip to content

build(deps): use the published dark-light release instead of its git repository - #696

Merged
pamburus merged 1 commit into
mainfrom
build/dark-light-from-crates-io
Aug 26, 2026
Merged

build(deps): use the published dark-light release instead of its git repository#696
pamburus merged 1 commit into
mainfrom
build/dark-light-from-crates-io

Conversation

@pamburus

@pamburus pamburus commented Aug 26, 2026

Copy link
Copy Markdown
Owner

The dark-light dependency was tracked from its git repository, which forced a pinned output hash in the Nix package. That pin is keyed by version, so it went stale as soon as the dependency's version moved — which is what breaks nix flake check on #695:

error: A hash was specified for dark-light-2.0.0, but there is no corresponding git dependency.

Version 3.0.0 is published on crates.io and carries the fixes the git revision was tracking, so the git source is no longer needed.

  • Depend on dark-light 3.0.0 from crates.io
  • Drop its now-unnecessary output hash from the Nix package

Resolving the registry version also pulls routine bumps of its transitive dependencies (zbus, zvariant, winreg) into the lockfile.

The detection API is unchanged between 2.0.0 and 3.0.0, so no code changes were needed.

Verification

  • cargo clippy --locked --all-targets --all-features clean
  • cargo test --locked --workspace passes
  • cargo run --locked works
  • nix flake check on this PR

…repository

The `dark-light` git dependency required a pinned output hash in the Nix package, which went stale whenever the dependency's version changed and broke `nix flake check`. The 3.0.0 release carries the fixes the git revision was tracking, so the pin is no longer needed.

Claude-Session: https://claude.ai/code/session_015xj4UfBGh2wJNZhFbGMs84
@pamburus
pamburus enabled auto-merge (squash) August 26, 2026 21:25
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.58%. Comparing base (7e9c1ed) to head (ffb3944).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #696   +/-   ##
=======================================
  Coverage   80.58%   80.58%           
=======================================
  Files          31       31           
  Lines        4218     4218           
=======================================
  Hits         3399     3399           
  Misses        819      819           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pamburus
pamburus merged commit 80905a7 into main Aug 26, 2026
12 checks passed
@pamburus
pamburus deleted the build/dark-light-from-crates-io branch August 26, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant