build(deps): use the published dark-light release instead of its git repository - #696
Merged
Merged
Conversation
…repository The `dark-light` git dependency required a pinned output hash in the Nix package, which went stale whenever the dependency's version changed and broke `nix flake check`. The 3.0.0 release carries the fixes the git revision was tracking, so the pin is no longer needed. Claude-Session: https://claude.ai/code/session_015xj4UfBGh2wJNZhFbGMs84
pamburus
enabled auto-merge (squash)
August 26, 2026 21:25
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 31 31
Lines 4218 4218
=======================================
Hits 3399 3399
Misses 819 819 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dark-lightdependency was tracked from its git repository, which forced a pinned output hash in the Nix package. That pin is keyed by version, so it went stale as soon as the dependency's version moved — which is what breaksnix flake checkon #695:Version 3.0.0 is published on crates.io and carries the fixes the git revision was tracking, so the git source is no longer needed.
dark-light3.0.0 from crates.ioResolving the registry version also pulls routine bumps of its transitive dependencies (
zbus,zvariant,winreg) into the lockfile.The detection API is unchanged between 2.0.0 and 3.0.0, so no code changes were needed.
Verification
cargo clippy --locked --all-targets --all-featurescleancargo test --locked --workspacepassescargo run --lockedworksnix flake checkon this PR