Fixed aliased pandas imports in namespace checker - #67075
Open
tskz48 wants to merge 3 commits into
Open
Conversation
Member
|
What problem is this fixing? |
github-actions
Bot
added
the
Awaiting Review
jbrockmendel
removed
the
Awaiting Review
jbrockmendel
requested changes
Sep 1, 2026
| parser.add_argument("paths", nargs="*") | ||
| parser.add_argument("--replace", action="store_true") | ||
| args = parser.parse_args(argv) | ||
| print("ARGS: ", args) |
| if node.module is not None and "pandas" in node.module: | ||
| self.imported_from_pandas.update(name.name for name in node.names) | ||
| self.imported_from_pandas.update( | ||
| name.name for name in node.names if name.asname is None |
Member
There was a problem hiding this comment.
what bug is this addressing?
Author
|
the change stops aliased pandas imports from being incorrectly flagged as
inconsistent namespace usage.
from pandas import DataFrame as DF
was being treated as if Dataframe had been imported directly. The change
only records direct panda imports if they were not given an alias.
…On Tue, Sep 1, 2026 at 6:52 AM jbrockmendel ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In scripts/check_for_inconsistent_pandas_namespace.py
<#67075 (comment)>:
> @@ -122,13 +124,18 @@ def main(argv: Sequence[str] | None = None) -> None:
parser.add_argument("paths", nargs="*")
parser.add_argument("--replace", action="store_true")
args = parser.parse_args(argv)
+ print("ARGS: ", args)
why?
------------------------------
In scripts/check_for_inconsistent_pandas_namespace.py
<#67075 (comment)>:
> @@ -55,7 +55,9 @@ def visit_Attribute(self, node: ast.Attribute) -> None:
def visit_ImportFrom(self, node: ast.ImportFrom) -> None:
if node.module is not None and "pandas" in node.module:
- self.imported_from_pandas.update(name.name for name in node.names)
+ self.imported_from_pandas.update(
+ name.name for name in node.names if name.asname is None
what bug is this addressing?
—
Reply to this email directly, view it on GitHub
<#67075?email_source=notifications&email_token=BHQ6WL5ID7RZDGV6A2LEVDL5MYQGLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBXGMYDGMZYGAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5073033802>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHQ6WL4QM25JRJ4EYTEBDR35MYQGLAVCNFSNUABCKJSXA33TNF2G64TZHM4DKOBRGI3TWSLTON2WKOZVGI4DKMBVGQYTIOFBOYBA>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BHQ6WL64QFNAG4NRGUO4WWL5MYQGLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBXGMYDGMZYGAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/BHQ6WL5F4YEHPKIRKRHARJT5MYQGLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBXGMYDGMZYGAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
<pandas-dev/pandas/pull/67075/review/5073033802 ***@***.***
com>
|
Author
|
The print statements were for debugging.
On Tue, Sep 1, 2026 at 10:36 AM Rohith Koti ***@***.***>
wrote:
… the change stops aliased pandas imports from being incorrectly flagged as
inconsistent namespace usage.
from pandas import DataFrame as DF
was being treated as if Dataframe had been imported directly. The change
only records direct panda imports if they were not given an alias.
On Tue, Sep 1, 2026 at 6:52 AM jbrockmendel ***@***.***>
wrote:
> ***@***.**** requested changes on this pull request.
> ------------------------------
>
> In scripts/check_for_inconsistent_pandas_namespace.py
> <#67075 (comment)>:
>
> > @@ -122,13 +124,18 @@ def main(argv: Sequence[str] | None = None) -> None:
> parser.add_argument("paths", nargs="*")
> parser.add_argument("--replace", action="store_true")
> args = parser.parse_args(argv)
> + print("ARGS: ", args)
>
> why?
> ------------------------------
>
> In scripts/check_for_inconsistent_pandas_namespace.py
> <#67075 (comment)>:
>
> > @@ -55,7 +55,9 @@ def visit_Attribute(self, node: ast.Attribute) -> None:
>
> def visit_ImportFrom(self, node: ast.ImportFrom) -> None:
> if node.module is not None and "pandas" in node.module:
> - self.imported_from_pandas.update(name.name for name in node.names)
> + self.imported_from_pandas.update(
> + name.name for name in node.names if name.asname is None
>
> what bug is this addressing?
>
> —
> Reply to this email directly, view it on GitHub
> <#67075?email_source=notifications&email_token=BHQ6WL5ID7RZDGV6A2LEVDL5MYQGLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBXGMYDGMZYGAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-5073033802>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BHQ6WL4QM25JRJ4EYTEBDR35MYQGLAVCNFSNUABCKJSXA33TNF2G64TZHM4DKOBRGI3TWSLTON2WKOZVGI4DKMBVGQYTIOFBOYBA>
> .
> Triage notifications, keep track of coding agent tasks and review pull
> requests on the go with GitHub Mobile for iOS
> <https://github.com/notifications/mobile/ios/BHQ6WL64QFNAG4NRGUO4WWL5MYQGLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBXGMYDGMZYGAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
> and Android
> <https://github.com/notifications/mobile/android/BHQ6WL5F4YEHPKIRKRHARJT5MYQGLA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBXGMYDGMZYGAZKM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
> Download it today!
> You are receiving this because you authored the thread.Message ID:
> <pandas-dev/pandas/pull/67075/review/5073033802 ***@***.***
> .com>
>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #xxxx (Replace xxxx with the GitHub issue number)
Tests added and passed if fixing a bug or adding a new feature
All code checks passed.
Added type annotations to new arguments/methods/functions.
Added an entry in the latest
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I have reviewed and followed all the contribution guidelines
Check exactly one of the following, per the automated contributions policy:
I did not use AI to develop this pull request.
I used AI to develop this pull request. I prompted it to follow
AGENTS.md, I have reviewed and understood every change, and I have described above how I used it and exactly which tool, model version, and effort setting — e.g.claude opus 4.8 (xhigh), not justclaude.