fix: restore declarations for incompatible selectors after rule merge - #1275
Open
PranavAchar01 wants to merge 3 commits into
Open
Conversation
…s them When a style rule has both compatible and incompatible selectors for the current targets, merge_style_rules drains the rule's declarations into the preceding compatible rule. This left the incompatible-selector clones with empty declarations, causing them to be silently dropped by is_empty(). Fix: snapshot the declarations before the merge attempt and restore them into each incompatible-selector clone. Fixes parcel-bundler#1260. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ible-selector-merge-drops-declarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge_style_rules(rule) = compatible(rule.selectors) → prev.declarations ∪ rule.declarations
| incompatible(rule.selectors) → clone(rule) with rule.declarations preserved
https://drafts.csswg.org/selectors-4/#has-pseudo
Fixes: #1260