fix: correct VendorPrefix for ::-ms-input-placeholder pseudo-element - #1281
Open
Noethix55555 wants to merge 1 commit into
Open
fix: correct VendorPrefix for ::-ms-input-placeholder pseudo-element#1281Noethix55555 wants to merge 1 commit into
Noethix55555 wants to merge 1 commit into
Conversation
Parsing ::-ms-input-placeholder stored VendorPrefix::Moz instead of VendorPrefix::Ms. The serializer checks for Moz vs WebKit/Ms to decide whether to emit 'input-placeholder' or 'placeholder', so a round-tripped ::-ms-input-placeholder was silently rewritten to ::-moz-placeholder. Add minify_test round-trip assertions for the three vendor-prefixed placeholder pseudo-elements to guard against regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/selector.rsline 294 maps the::-ms-input-placeholderpseudo-element toVendorPrefix::Mozinstead ofVendorPrefix::Ms— a copy-paste error from the line above (-moz-placeholder).The serializer at line 1244 branches on the stored prefix:
Because the stored prefix is
Moz, the wrong branch fires: the-moz-vendor prefix is written, andplaceholder(notinput-placeholder) is appended. Any stylesheet that already contains::-ms-input-placeholderis silently rewritten to::-moz-placeholder— a completely different selector.Repro:
Before this fix, lightningcss outputs:
After this fix:
Fix: change
VendorPrefix::MoztoVendorPrefix::Mson line 294. Three round-tripminify_testassertions are added to prevent regression.