Fix invalid selectors - #1309
Open
snowystinger wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1239
unlike
:isand:wherewhich are forgiving selectors and can be empty,:hasis not.https://www.w3.org/TR/selectors-4/#forgiving-selector
https://www.w3.org/TR/selectors-4/#changes-2022-05
The only thing I'm a little confused on is https://www.w3.org/TR/selectors-4/#has-allowed-pseudo-element says
I'm not sure what the other specifications are which would define these. We could introduce support for this in the future though. Given that it was already removing the inside selector in some scenarios I think this isn't introducing a regression for anyone trying to use an "other specification" allowed pseudo element.
This would've caught and prevented adobe/react-spectrum#10468