Add failing test for composing default class - #909
Open
mrginglymus wants to merge 2 commits into
Open
Conversation
mrginglymus
force-pushed
the
compose-default
branch
2 times, most recently
from
February 4, 2025 13:26
bd6613a to
eb187a4
Compare
mrginglymus
force-pushed
the
compose-default
branch
from
February 4, 2025 13:31
eb187a4 to
c217f27
Compare
mrginglymus
commented
Feb 4, 2025
| input: &mut Parser<'i, 't>, | ||
| ) -> Result<CustomIdent<'i>, ParseError<'i, ParserError<'i>>> { | ||
| let name = CustomIdent::parse(input)?; | ||
| let name = CustomIdent(input.expect_ident()?.into()); |
Author
There was a problem hiding this comment.
Well this fixes the test case above, but I have no idea what I'm doing...
mrginglymus
marked this pull request as ready for review
February 5, 2025 08:12
Author
|
@devongovett I've now encountered this in my codebase; could you please take a look at this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default#908I'll do my best to see if I can find where/why this is happening...