Open
Conversation
Fixes an issue with callback not being fired if there are not enough post in the feed to reach the limit.
HartLarsson
added a commit
to HartLarsson/social-feed
that referenced
this pull request
Apr 24, 2016
Added Callback fix, see: pavelk2#173 Added new RSS features to read blogs and Rssfeeds with html and pics.
HartLarsson
added a commit
to HartLarsson/social-feed
that referenced
this pull request
Jul 6, 2016
new rendering system pavelk2#171 new callback fix pavelk2#173 New RSS implementation to get Images from RSS feed fix staging_resource for facebook
|
Found an issue where the Fixed it by adding the following (using twitter as an example) // js/jquery.socialfeed.js line 264
var post = new SocialFeedPost('twitter', Feed.twitter.utility.unifyPostData(element));
var render_successful = post.render();
// If we do not render the post because it was a duplicate or something, reduce the
// completion counter so that the `loaded_post_count` and `posts_to_load_count` resolve to equal
if(!render_successful)
posts_to_load_count-- |
Contributor
|
there was already a fix that works perfectly, for example for twitter 1fe5903: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue with callback not being fired if there are not enough post in the feed to reach the limit.
Also fixes an error if pinterest response is empty