fix(formats): resolve nested remote requirement URLs - #3851
Merged
frostming merged 1 commit intoAug 17, 2026
Conversation
frostming
approved these changes
Aug 17, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3851 +/- ##
==========================================
+ Coverage 88.43% 88.44% +0.01%
==========================================
Files 121 121
Lines 13262 13268 +6
Branches 2252 2254 +2
==========================================
+ Hits 11728 11735 +7
+ Misses 965 964 -1
Partials 569 569
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-rreferences against a remote requirements file URLfileURLsRoot cause and impact
RequirementParser._parse_line()resolved every nested requirements reference withpathlib.Path. For a remote parent such ashttps://example.com/base/requirements.txt, this collapsed the URL intohttps:/example.com/base/child.txt, so importing a valid remote requirements tree failed at the first relative-rline.The parser now uses URL joining when the parent is remote, while retaining
Pathjoining for local files.Fixes #3850.
Validation
pytest -q tests/test_formats.py(56 passed)ruff check src/pdm/formats/requirements.py tests/test_formats.pyruff format --check src/pdm/formats/requirements.py tests/test_formats.pygit diff --checkPull Request Checklist
news/describing what is new.