Overhaul of chapter 1 - #235
Open
David-Stelter wants to merge 5 commits into
Open
Conversation
…awkward or unusual phrasing, and eliminating repetitions.
…r changes since master-2025-11-22
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the generated Quarto site assets (HTML/CSS/JS) and build tooling, including changes to search highlighting/URL handling, navigation behavior, and tabset persistence behavior.
Changes:
- Pin Zig toolchain in
flake.nixto a specific version attribute. - Regenerate Quarto site assets (Quarto version appears to change, and multiple JS/CSS bundles are updated).
- Refactor client-side behavior for search highlighting, tabsets persistence, and TOC/category activation logic.
Reviewed changes
Copilot reviewed 15 out of 36 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| flake.nix | Pins Zig dependency via zig.packages.${system}."0.16.0". |
| docs/site_libs/quarto-search/quarto-search.js | Reworks query handling/highlighting and alters Algolia insights init + Fuse subindex creation logic. |
| docs/site_libs/quarto-nav/quarto-nav.js | Removes announcement bar registration logic. |
| docs/site_libs/quarto-html/tabsets/tabsets.js | Deletes standalone grouped-tabsets module (logic moved elsewhere). |
| docs/site_libs/quarto-html/quarto.js | Inlines grouped-tabsets logic, changes TOC/category activation logic, and alters selector construction and iteration code. |
| docs/site_libs/quarto-html/quarto-syntax-highlighting-dark-23bbe8b5e4efc1e257f6d59dce478b08.css | Regenerated syntax highlighting CSS (ordering + sourcemap reference). |
| docs/site_libs/quarto-html/quarto-syntax-highlighting-acf12a64177840b8d86f2d4f01b2e9fb.css | Regenerated syntax highlighting CSS (ordering + sourcemap reference). |
| docs/site_libs/bootstrap/bootstrap-icons.css | Downgrades Bootstrap Icons version and updates font hash + icon list. |
| docs/index.html | Regenerated HTML (script loading mode, theming bootstrap links, ARIA labels, etc.). |
| docs/Chapters/references.html | Regenerated HTML (title format, theming bootstrap links, bibliography markup). |
| docs/Chapters/15-vectors.html | Regenerated HTML and changes math script loading + KaTeX render guards. |
| docs/Chapters/03-unittests.html | Regenerated HTML (script loading mode, theming bootstrap links, ARIA labels, etc.). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </a> | ||
| <button type="button" class="btn quarto-search-button" aria-label="Search" onclick="window.quartoOpenSearch();"> | ||
| <button type="button" class="btn quarto-search-button" aria-label="" onclick="window.quartoOpenSearch();"> |
Comment on lines
+131
to
132
| if (mathElements[i].tagName == "SPAN") { | ||
| window.katex.render(texText.data, mathElements[i], { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through Chapter 1 to clean up the text and correct some terms. I also upgraded the Flake to use Zig 0.16.0 so it builds properly with the new
mainsignature.Main changes
Chapter 1 (01-zig-weird.qmd):
[16:0]u8takes up 16 + 1 bytes in memory due to the sentinel.Nix Flake:
mainsignature withinit, since the previously pinned master build was causing compile errors.I recompiled the book and everything renders without issues on a local preview.
I assign the copyright of this contribution to Pedro Duarte Faria