test: add new unit test in test case reconnect#1277
Open
diaslui wants to merge 2 commits intopeers:masterfrom
Open
test: add new unit test in test case reconnect#1277diaslui wants to merge 2 commits intopeers:masterfrom
diaslui wants to merge 2 commits intopeers:masterfrom
Conversation
diaslui
commented
May 20, 2024
Author
diaslui
left a comment
diaslui
left a comment
There was a problem hiding this comment.
After implementing the test, I analyzed whether it would fulfill its role by causing it to give an error on purpose, and I confirmed its effectiveness in avoiding future bugs after reconnecting and disconnecting, everything is ok.
WofWca
approved these changes
May 21, 2024
Contributor
WofWca
left a comment
WofWca
left a comment
There was a problem hiding this comment.
IDK how valuable the test is, but its code looks fine.
Author
|
the tabulation problem has been resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was added?
A new test named as: (reconnect => disconnect => destroy) has been added in the "reconnect" test case in the test/peer.spec.ts file
How important is this new test?
This new test is important because there were already other tests that analyzed cases such as disconnect => reconnect but not the opposite, reconnect => disconnect, which could allow bugs to pass after reconnecting and disconnecting. This was solved by adding the new test that checks if everything will be ok after reconnecting and disconnecting
What was done after implementing the new test?
After implementing the test, I analyzed whether it would fulfill its role by causing it to give an error on purpose, and I confirmed its effectiveness in avoiding future bugs after reconnecting and disconnecting, everything is ok.
It's OK, Tested and Approved
I hope you accept the PR with the test to avoid future bugs! Thank you for your attention