feat: Expose addEventListner to allow for proper use of the underlying websocket#1305
Open
TesDevelopment wants to merge 1 commit intopeers:masterfrom
Open
feat: Expose addEventListner to allow for proper use of the underlying websocket#1305TesDevelopment wants to merge 1 commit intopeers:masterfrom
TesDevelopment wants to merge 1 commit intopeers:masterfrom
Conversation
TesDevelopment
changed the title
WofWca
reviewed
Oct 18, 2024
Contributor
WofWca
left a comment
WofWca
left a comment
There was a problem hiding this comment.
I suppose a removeEventListener would also make sense. But at this point why not just make _socket public instead,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been working on a project recently and I noticed that there is no safe way to listen to the underlying websocket, I assumed this was because you weren't intended to but it looks like PeerServer actively supports sending and listening to the websocket so this seems like an oversight to me.