Url encode srcset values#91
Merged
patrickfournier merged 5 commits intopelican-plugins:mainfrom Mar 17, 2025
Merged
Conversation
This prevents errors with url that contains whitespaces or commas.
Member
|
The code here looks good (and is fine to merge)! Thank you for tackling this long standing issue. And thank you for providing tests! @justinmayer What is the best way to make sure that the Changelog is updated, and a new release is cut with this collection of fixes that have merged in the last bit? Should we be adding something to the Readme about providing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encode URLs in
srcsetwhen they contain a space or a comma, as those characters have a special meaning in the context of asrcsetvalue.Fixes #78