Conversation
justinmayer
left a comment
There was a problem hiding this comment.
Hey Leonardo! 👋 Nice work. I made some suggested changes, mainly related to ensuring the changes in this PR will properly result in a successful automatic release, powered by AutoPub.
After this PR is merged, one other suggestion would be to add Cruft to this plugin, which will allow you to easily pull in changes from the upstream plugin template via cruft update (or invoke update). That way, certain enhancements that apply to all plugins can be easily applied to this project without having to manually make such changes yourself ✨
|
Thanks @justinmayer, I completely forgot about AutoPub 🤦 I applied your suggestions, please have another look! |
justinmayer
left a comment
There was a problem hiding this comment.
Latest changes look good to me! 👍
This PR updates the plugin to Mau version 5 (https://github.com/Project-Mau/mau/tree/5.0.0)