Open
Conversation
Remediate all zizmor findings across both workflow files:
ci.yml:
- Add permissions: {} at workflow level and contents: read at job level
- Add persist-credentials: false to checkout
- Pin actions/checkout and actions/setup-node to SHA hashes
release.yml:
- Add persist-credentials: false to checkout
- Pin actions/checkout and actions/setup-node to SHA hashes
- Add environment: release to the job for secrets scoping
- Replace ${{ steps.check.outputs.* }} in run blocks with env variables
- Replace softprops/action-gh-release with gh release create
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: persist-credentials: false breaks git push in release workflow
- Removed persist-credentials: false from release workflow checkout step to allow git push operations to authenticate using the default persisted credentials.
… git push The release workflow needs to push git tags, which requires authentication. Setting persist-credentials: false removes the credential helper configured by actions/checkout, causing git push to fail. Removing this setting allows the default behavior (persist-credentials: true) which preserves credentials for authenticated git operations.
The artipacked finding doesn't apply here — this workflow never uploads artifacts, so there's no vector for credential leakage. Keeping credentials allows the downstream git push step to work. Added inline zizmor suppression comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Remediate all findings from
zizmorstatic analysis across both GitHub Actions workflow files.ci.yml:
permissions: {}at workflow level andpermissions: { contents: read }at job level (excessive-permissions)persist-credentials: falseto checkout (artipacked)actions/checkoutandactions/setup-nodeto SHA hashes (unpinned-uses)release.yml:
persist-credentials: falseto checkout (artipacked)actions/checkoutandactions/setup-nodeto SHA hashes (unpinned-uses)environment: releaseto the job (secrets-outside-env) — you'll need to create a "release" environment in your repo's Settings > Environments and add theNPM_TOKENsecret there${{ steps.check.outputs.* }}inrun:blocks withenv:variables (template-injection)softprops/action-gh-releasewithgh release create(superfluous-actions, unpinned-uses, cache-poisoning)Test plan
zizmor .reports 0 findings (5 suppressed)NPM_TOKENsecret thereNote
Medium Risk
Touches CI/release automation and permissioning; mistakes could block releases or tagging, but changes are largely security hardening and action pinning.
Overview
Hardens GitHub Actions CI and release workflows per security audit findings.
CI now defaults to
permissions: {}with job-scopedcontents: read, pinsactions/checkout/actions/setup-nodeto SHAs, and disables checkout credential persistence.Release now runs in a protected
environment: release, avoids expression interpolation inside shell scripts by moving values toenv, and replacessoftprops/action-gh-releasewith directgh release createusingGH_TOKENfor publishing GitHub releases.Written by Cursor Bugbot for commit 6025e28. This will update automatically on new commits. Configure here.