fix fi overflow panic because of multi 'in values' in query text#58
Open
zanjie wants to merge 3 commits intopercona:masterfrom
Open
fix fi overflow panic because of multi 'in values' in query text#58zanjie wants to merge 3 commits intopercona:masterfrom
zanjie wants to merge 3 commits intopercona:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 67.25% 67.07% -0.19%
==========================================
Files 7 7
Lines 1408 1400 -8
==========================================
- Hits 947 939 -8
Misses 349 349
Partials 112 112
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TarmoKople
pushed a commit
to TarmoKople/go-mysql
that referenced
this pull request
Feb 28, 2022
percona-csalguero
approved these changes
Feb 22, 2023
|
root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the real reason that fi overflow cause index out of range panic is the length of variable f slice need increament when in values length in quota is less than 2
sql: select col1 from tb1 where cond1 in(1) and cond2 in(2);

Fingerprint(sql) got panic: index out of range
after fix
