This repository was archived by the owner on Aug 24, 2022. It is now read-only.
Draft
Conversation
BupycHuk
reviewed
Jul 20, 2021
| if !s.waitUntilReady(conn, l) { | ||
| l.Errorf("Failed to establish two-way communication channel.") | ||
| } | ||
| streamCtx, streamCancel := context.WithCancel(context.Background()) |
Contributor
There was a problem hiding this comment.
this doesn't override streamCancel, so https://github.com/percona/pmm-agent/pull/282/files#diff-181c0efbb5b86fbcca31d699687ecec527e9818a5835bfe36cac81f691604392R178 will cancel another stream.
| conn.Close() | ||
| return | ||
| } | ||
| s.s = stream |
Contributor
There was a problem hiding this comment.
this replacement should be done more safety, it can cause race condition.
askomorokhov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PMM-7000
TBD: Tests.