Skip to content

PMM-9875 Errors view usage.#914

Closed
JiriCtvrtka wants to merge 12 commits intomainfrom
PMM-9875-errors-view-usage
Closed

PMM-9875 Errors view usage.#914
JiriCtvrtka wants to merge 12 commits intomainfrom
PMM-9875-errors-view-usage

Conversation

@JiriCtvrtka
Copy link
Copy Markdown
Contributor

PMM-9875

Original PR: percona/pmm-agent#370

Build: SUBMODULES-0

  • Links to other linked pull requests (optional).

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 27, 2022

Codecov Report

Merging #914 (3ad90e1) into main (a4e879e) will increase coverage by 0.91%.
The diff coverage is 11.11%.

❗ Current head 3ad90e1 differs from pull request most recent head ff8d677. Consider uploading reports for the commit ff8d677 to get more accurate results

@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
+ Coverage   44.05%   44.97%   +0.91%     
==========================================
  Files         334      330       -4     
  Lines       39790    39510     -280     
==========================================
+ Hits        17528    17768     +240     
+ Misses      20737    20193     -544     
- Partials     1525     1549      +24     
Flag Coverage Δ
agent 53.71% <11.11%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agent/agents/postgres/pgstatmonitor/models.go 0.00% <ø> (ø)
...ent/agents/postgres/pgstatmonitor/pgstatmonitor.go 12.83% <0.00%> (-1.10%) ⬇️
...ent/agents/postgres/pgstatmonitor/models_reform.go 52.59% <21.62%> (-9.80%) ⬇️
managed/services/server/server.go 34.38% <0.00%> (-0.50%) ⬇️
admin/cli/cli.go 0.00% <0.00%> (ø)
managed/models/database.go 45.29% <0.00%> (ø)
managed/cmd/pmm-managed/main.go 0.00% <0.00%> (ø)
managed/services/agents/state.go 0.00% <0.00%> (ø)
managed/services/agents/log_level.go 36.36% <0.00%> (ø)
managed/services/alertmanager/alertmanager.go 51.07% <0.00%> (ø)
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@it-percona-cla
Copy link
Copy Markdown
Contributor

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ JiriCtvrtka
❌ Jiri Ctvrtka


Jiri Ctvrtka seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.


// makeBuckets uses current state of pg_stat_monitor table and accumulated previous state
// to make metrics buckets.
func (m *PGStatMonitorQAN) makeBuckets(current, cache map[time.Time]map[string]*pgStatMonitorExtended) []*agentpb.MetricsBucket {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
cognitive complexity 38 of func (*PGStatMonitorQAN).makeBuckets is high (> 30) (gocognit)

return buckets, nil
}

func (m *PGStatMonitorQAN) checkErrorsView(ctx context.Context) error {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci-lint] reported by reviewdog 🐶
calculated cyclomatic complexity for function checkErrorsView is 12, max is 10 (cyclop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants