Fix #2635: ShowStartMarkers shows expanded data-driven test names#2728
Draft
nohwnd wants to merge 1 commit into
Draft
Fix #2635: ShowStartMarkers shows expanded data-driven test names#2728nohwnd wants to merge 1 commit into
nohwnd wants to merge 1 commit into
Conversation
Moved the start marker output from the EachTestSetupStart plugin step (which fires before name expansion) to a setup scriptblock that runs right after the template expansion in the runtime. This ensures data-driven test names like 'Iteration <_>' display as 'Iteration 1' instead of the raw template. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2635
When
Debug.ShowStartMarkersis enabled, data-driven test names likeIteration <_>were showing the raw template instead of the expanded name (Iteration 1).The start marker output was in the
EachTestSetupStartplugin step, which fires before the<>template expansion runs. Moved it to a setup scriptblock that executes right after name expansion in the runtime, so markers now show the fully expanded test name.Added a test that verifies data-driven
-ForEachnames are expanded in start markers.