Fix #2585: Prevent $WhatIfPreference from breaking Pester#2730
Merged
Conversation
Set $WhatIfPreference = $false at the start of Invoke-Pester's begin block. When a caller sets $WhatIfPreference = $true, it leaks into Pester's internal commands (New-Item, Remove-Item, etc.) and causes test execution to fail with cryptic errors or excessive 'What if:' messages. The local assignment scopes it to Invoke-Pester and its children without affecting the caller's preference. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2585
When
\$WhatIfPreference = \$trueleaks into Pester from the caller's scope, internal commands likeNew-ItemandRemove-Itemget 'What if:' output instead of executing, causing test discovery and execution to fail.Sets
\$WhatIfPreference = \$falseat the start ofInvoke-Pesterto isolate Pester internals from the caller's preference. The caller's own\$WhatIfPreferenceis not modified.