Skip to content

Bump Go, dependencies, Actions#28

Merged
ordovicia merged 6 commits intomasterfrom
bump-deps
Apr 21, 2025
Merged

Bump Go, dependencies, Actions#28
ordovicia merged 6 commits intomasterfrom
bump-deps

Conversation

@ordovicia
Copy link
Copy Markdown
Contributor

@ordovicia ordovicia commented Apr 21, 2025

This pull request updates Go version, Go package dependencies, tools, and GitHub Actions.

Actually I attempted to re-scaffold the entire project using newer kubebuilder, but the tests do not pass with the new codebase, and I could not solve that in some hours 😢

@ordovicia ordovicia requested a review from Copilot April 21, 2025 08:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the Go version, updates package dependencies, and modernizes GitHub Actions and CRD annotations.

  • Updates controller-runtime configuration in main.go to use the new metrics server options.
  • Adopts context-aware list functions in controllers and improves test stability with eventual assertions.
  • Upgrades GitHub Actions workflows to use the latest versions and updates CRD controller-gen annotations.

Reviewed Changes

Copilot reviewed 15 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
main.go Migrates metrics configuration to use server.Options
controllers/suite_test.go Replaces direct Update calls with Eventually for improved stability
controllers/noderemediationtemplate_controller.go Uses context-aware nodeMapFn for listing templates
controllers/noderemediation_controller.go Adopts context-aware map function and streamlines Watch syntax
config/rbac/role.yaml Refactors RBAC rules, adding new pods/eviction permissions and cleanup
config/crd/bases/*.yaml Updates controller-gen versions and refines description formatting
api/v1alpha1/zz_generated.deepcopy.go Removes legacy build tag in favor of the new build constraint
.github/workflows/*.yaml Upgrades Actions steps with newer versions
Files not reviewed (3)
  • Dockerfile: Language not supported
  • Makefile: Language not supported
  • go.mod: Language not supported

@ordovicia ordovicia requested a review from y1r April 21, 2025 08:36
Copy link
Copy Markdown

@y1r y1r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attempted to re-scaffold the entire project using newer kubebuilder, but the tests do not pass with the new codebase, and I could not solve that in some hours

Thank you for trying re-scaffolding! Updating dependencies is enough for now. Thank you for sending PR.

@ordovicia ordovicia merged commit a4dde6a into master Apr 21, 2025
2 checks passed
@ordovicia ordovicia deleted the bump-deps branch April 21, 2025 08:46
@github-actions github-actions bot mentioned this pull request Apr 21, 2025
@ordovicia ordovicia mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants