feat: add dose-normalised summary slides to PPT/QMD export (#1054)#1229
Open
feat: add dose-normalised summary slides to PPT/QMD export (#1054)#1229
Conversation
This reverts commit 48e05a6.
- Replace two `calculate_summary_stats()` calls with a single `all_stats_i` computation filtered twice into `stats_i` and `dose_norm_stats_i` - Add missing `@param dose_norm_parameters` to `get_dose_esc_results()` roxygen - Remove extra alignment spaces on `dose_norm_meanplot =` in output list
Add .add_pptx_dose_norm_slide() helper, wire it into .add_pptx_group_summary(), extend .add_pptx_ind_slides() with dose_norm_ind_params support, and update has_summary guard in .process_pptx_group_slides(). NULL guards ensure backward compat with group data that lacks the new fields.
Extract .add_pptx_one_ind_slide() and .add_pptx_dose_norm_ind_slides() from .add_pptx_ind_slides() to bring cyclomatic complexity from 23 to 15.
Extract .add_qmd_dose_norm_summary_slide(), .add_qmd_dose_norm_ind_slides(), and .qmd_active_groups() helpers so that .add_qmd_summary_slides(), .add_qmd_ind_slides(), and create_qmd_dose_slides() each stay within the cyclocomp limit of 15.
- Gate dose-norm validation on available choices being non-empty so the error does not fire when no dose-norm parameters were computed in the run - Add dose_norm_available_rv reactiveVal to persist available codes for the slide_validation reactive - Group dose-norm parameter choices by unit_type (conc_dosenorm, auc_dosenorm, aumc_dosenorm) using .dose_norm_param_choices() - Match virtualSelectInput styling (width, tags, descriptions) to the other three parameter selectors; remove dropboxWrapper - Rename slide sections: "Dose-Normalised Plot & Statistics" (summary) and "Dose-Normalised Plots & Parameters" (individual) to better reflect content shown (#1054)
Dose-normalised individual slides (per-subject plots and parameter tables) are out of scope for #1054. Remove ind_dose_norm_params and ind_dose_norm_plots from the results builder, rendering helpers, and slide tree. Only the summary-level dose-normalised plot + statistics slide is retained. Also rename virtual selector group labels to human-readable strings: conc_dosenorm -> "Concentration (Dose Norm.)" auc_dosenorm -> "AUC (Dose Norm.)" aumc_dosenorm -> "AUMC (Dose Norm.)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1054
Description
Adds opt-in dose-normalised summary slides to the PPT/QMD export. Each dose group gains a Dose-Normalised Plot & Statistics slide showing a dose-normalised mean concentration-time plot alongside a summary statistics table (filtered to user-selected dose-norm parameters).
Key changes:
get_dose_esc_results()extended withdose_norm_parametersargument; computesdose_norm_meanplotanddose_norm_statisticsper group using existingexploration_meanplot(..., line_type = "dose-normalized")andcalculate_summary_stats()helpersofficer-utils.R) and QMD (quarto-utils.R) export pathsDefinition of Done
How to test
.qmdreferencesdose_norm_meanplotanddose_norm_statisticsContributor checklist
.scsschange was done, rundata-raw/compile_css.R