Skip to content

Closes #63 add onco table and plot examples#148

Open
jeffreyad wants to merge 26 commits intomainfrom
63-add-onco-table-and-plot-examples
Open

Closes #63 add onco table and plot examples#148
jeffreyad wants to merge 26 commits intomainfrom
63-add-onco-table-and-plot-examples

Conversation

@jeffreyad
Copy link
Copy Markdown
Collaborator

@jeffreyad jeffreyad commented Feb 19, 2026

Pull Request

DESCRIPTION GOES HERE

Before you submit your pull request, take a look at the following checklist. Many thanks for your contribution!

  • Title: Place Closes #<insert_issue_number> at the beginning of your PR title. Use the Edit button in the top-right if you need to update.
  • Linked Issue: Ensure the related issue is linked in the "Development Section" on the right-hand side.
  • First Contribution: If this is your first contribution, add yourself to the DESCRIPTION file.
  • Impact on Examples: If your updates impact any examples, review locally for warnings or errors in the impacted example pages.
  • Merge Conflicts: Developers should address any merge conflicts and merge upon successful review.
  • New Packages: If new packages were used, ensure they are included in the DESCRIPTION file's Imports section.
  • Updated Examples: If you added or updated an example, ensure it runs on the latest CRAN release versions of all packages used.
  • Testing Instructions: Provide instructions on how to test the code if necessary.

@jeffreyad jeffreyad linked an issue Feb 19, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very savvy with oncology stuff - but looks really nice from a quick glance.

maybe some folks from admiral onco team would be able to help with review - @bundfussr @pharmaverse/admiralonco any interest?

Comment thread tlg/oncology_survival.qmd Outdated
Comment thread tlg/oncology_survival.qmd
Comment thread tlg/oncology_survival.qmd Outdated
Comment thread tlg/oncology_survival.qmd
Comment thread tlg/oncology_survival.qmd Outdated
Comment thread tlg/oncology_survival.qmd
Comment thread tlg/oncology_survival.qmd
Comment thread tlg/oncology_survival.qmd
@rossfarrugia rossfarrugia removed their request for review February 25, 2026 09:41
@github-actions
Copy link
Copy Markdown
Contributor

@Fanny-Gautier
Copy link
Copy Markdown
Collaborator

The website is available at https://pharmaverse.github.io/examples/63-add-onco-table-and-plot-examples.

The link provides a 404 file not found page.
image

Could you please check the cause? It would be helpful to have it working, as I can no longer run the website from my end. Thank you.

@bundfussr
Copy link
Copy Markdown
Collaborator

The link provides a 404 file not found page.

Could you please check the cause? It would be helpful to have it working, as I can no longer run the website from my end.

I think the issue is that the "Build and Deploy Website" workflow runs every day and it removes all files in the gh-pages branch before deploying the new website, i.e., all PR websites are removed. We could update the workflow such that existing files are not removed.

@pawelru , @rossfarrugia , do you see any issues with this update?

@rossfarrugia
Copy link
Copy Markdown
Contributor

Not sure why that workflow runs every day, I would have expected it to only run upon new merge requests - I'm open to simplifying that unless anyone spots anything i'm missing here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Onco Table and Plot examples

6 participants