Skip to content

Speed up#6

Merged
jecisc merged 1 commit intomasterfrom
speed-up
Mar 4, 2026
Merged

Speed up#6
jecisc merged 1 commit intomasterfrom
speed-up

Conversation

@jecisc
Copy link
Copy Markdown
Member

@jecisc jecisc commented Mar 4, 2026

This change is speeding up the project by caching the rules and not recreate all the regex all the time.

I have a snippet plurializing a big list of words, and it becomes 5 times faster with this change.

I think we can do even better by maybe not using so much regexes, but it's a first step with an already nice impact

This change is speeding up the project by caching the rules and not recreate all the regex all the time.

I have a snippet plurializing a big list of words, and it becomes 5 times faster with this change. 

I think we can do even better by maybe not using so much regexes, but it's a first step with an already nice impact
@jecisc jecisc mentioned this pull request Mar 4, 2026
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 4, 2026

Pull Request Test Coverage Report for Build 22678823835

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 174 of 180 (96.67%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 99.359%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/SingularizePluralize/SingularizePluralizeRule.class.st 51 57 89.47%
Totals Coverage Status
Change from base Build 22676007114: -0.6%
Covered Lines: 930
Relevant Lines: 936

💛 - Coveralls

@jecisc jecisc merged commit 0b3b48f into master Mar 4, 2026
5 of 12 checks passed
@jecisc jecisc deleted the speed-up branch March 4, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants