Fix get_class return type

[VincentLanglet]

Closes #2350
Closes phpstan/phpstan#4890

[ondrejmirtes]

I feel like a proper solution would be a new Type method. Basically the opposite of getClassStringObjectType. That one goes from class-string<Foo> to Foo.

We need to go from object Foo to class-string<Foo>.

And personally I don't think there's anything wrong with class-string<object{foo: Bar}> because it'd allow for a precise type when doing new on it again.

[VincentLanglet]

I feel like a proper solution would be a new Type method. Basically the opposite of getClassStringObjectType. That one goes from class-string<Foo> to Foo.

We need to go from object Foo to class-string<Foo>.

I introduced getClassStringType(), feel free to challenge the name :)

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

Would be nice to document what this is supposed to return similarly to how getClassStringObjectType and getObjectTypeOrClassStringObjectType are documented.

[VincentLanglet]

I added Return class-string<Foo> for object type Foo. ; is it enough ?

[staabm]

from my experience enum-case can generate a separate class of bugs, therefore I think we should have a separate test for it

[VincentLanglet]

I don't understand which test you expect since the bug was about class with hasProperty and an enum-case cannot have a property.

[staabm]

but it could have a method

[VincentLanglet]

I might be wrong but since an enum is final method_exists calls will be either always true or always false on it and the HasMethodType won't be added.

I'm getting

enum MyEnum
{
	case CASE1;
	case CASE2;

	public function someMethod(): bool { return true; }
}

class HelloWorld
{
	public function withEnumCase(): void
	{
		$entity = MyEnum::CASE1;
		assertType('class-string<Bug4890PHP8\MyEnum>', get_class($entity));
		assert(method_exists($entity, 'someMethod'));
		assertType('class-string<Bug4890PHP8\MyEnum>', get_class($entity));
	}
}

Do you have a test in mind ?

[staabm]

what about

enum MyEnum
{
	case CASE1;
	case CASE2;

	public function someMethod(): bool { return true; }
}

class HelloWorld
{
	public function withEnumCase(UnitEnum $entity): void
	{
		assertType('class-string<UnitEnum>', get_class($entity));
		assert(method_exists($entity, 'someMethod'));
		assertType('class-string<UnitEnum&hasMethod<someMethod>>', get_class($entity));
	}
}

$h = new HelloWorld();
$h->withEnumCase(MyEnum::CASE1);

[VincentLanglet]

Right, I forgot bout the base enum classes... UnitEnum.

I added the test !

[staabm]

might also be worth testing with templates

[VincentLanglet]

Also added

[staabm]

This PR is so much better than my take in #2350

great job!

[VincentLanglet]

Since you initially request changes, I need your approval @ondrejmirtes

[ondrejmirtes]

Thank you!