TypeSpecifier: Prevent duplicate expression printing#5018
Merged
staabm merged 1 commit intophpstan:2.1.xfrom Feb 21, 2026
Merged
TypeSpecifier: Prevent duplicate expression printing#5018staabm merged 1 commit intophpstan:2.1.xfrom
staabm merged 1 commit intophpstan:2.1.xfrom
Conversation
Collaborator
|
This pull request has been marked as ready for review. |
| $sureNotTypes[$exprString] = [$expr, $type]; | ||
| if ($exprString !== $originalExprString) { | ||
|
|
||
| if ($expr !== $originalExpr) { |
Contributor
There was a problem hiding this comment.
Is it really saving calls ? The code was comparing the string but now you are comparing the expr.
Also should you still check string after in case two expr has the same string print ? (Dunno if its possible)
Contributor
Author
There was a problem hiding this comment.
updated the PR description with a diff
Contributor
Author
There was a problem hiding this comment.
the 2 expressions involved can be compared this way, because they originate from a assignment a few lines above
Contributor
Author
There was a problem hiding this comment.
also note that even if we theoretically would preduce the same string again, we would overwrite the previous existing value with the very same touple again
VincentLanglet
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
its invoked a lot
only very minor improvements
before/after PR diff
blackfire run --ignore-exit-status php bin/phpstan analyse src/Analyser/ -v --debug