Skip to content

Comments

tiflash: correct the default values of logger.size and logger.count#21366

Closed
hfxsd wants to merge 1 commit intopingcap:masterfrom
hfxsd:logger.size-and-logger.count
Closed

tiflash: correct the default values of logger.size and logger.count#21366
hfxsd wants to merge 1 commit intopingcap:masterfrom
hfxsd:logger.size-and-logger.count

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Feb 14, 2026

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lance6716 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hfxsd hfxsd self-assigned this Feb 14, 2026
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 14, 2026
@hfxsd hfxsd requested a review from CalvinNeo February 14, 2026 01:13
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Feb 14, 2026

- 单个日志文件的大小。
- 默认值:`"100M"`
- 默认值:`"1000M"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TiFlash still use "100M" as the logger.size default and "10" as the logger.count default in the codebase. https://github.com/pingcap/tiflash/blob/661e9b5887144636797a3e6e583d5a383ebfd17e/libs/libdaemon/src/BaseDaemon.cpp#L758
"1000M" and "20" comes from the tiflash configuration hard code in tiup cluster https://github.com/pingcap/tiup/blob/c567110b2bc3a3d560fd6a04c04be538758a60e0/pkg/cluster/spec/tiflash.go#L559-L560

@hfxsd hfxsd closed this Feb 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution This PR is from a community contributor. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants