tiflash: correct the default values of logger.size and logger.count#21366
tiflash: correct the default values of logger.size and logger.count#21366hfxsd wants to merge 1 commit intopingcap:masterfrom
logger.size and logger.count#21366Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| - 单个日志文件的大小。 | ||
| - 默认值:`"100M"` | ||
| - 默认值:`"1000M"` |
There was a problem hiding this comment.
TiFlash still use "100M" as the logger.size default and "10" as the logger.count default in the codebase. https://github.com/pingcap/tiflash/blob/661e9b5887144636797a3e6e583d5a383ebfd17e/libs/libdaemon/src/BaseDaemon.cpp#L758
"1000M" and "20" comes from the tiflash configuration hard code in tiup cluster https://github.com/pingcap/tiup/blob/c567110b2bc3a3d560fd6a04c04be538758a60e0/pkg/cluster/spec/tiflash.go#L559-L560
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?