Cherry-pick CSV parser for GIN (RTA-8526)#81
Open
bkm71A wants to merge 3 commits intopinterest:pinterest-integration-4.1.0-rcfrom
Open
Cherry-pick CSV parser for GIN (RTA-8526)#81bkm71A wants to merge 3 commits intopinterest:pinterest-integration-4.1.0-rcfrom
bkm71A wants to merge 3 commits intopinterest:pinterest-integration-4.1.0-rcfrom
Conversation
Appply "[Feature] Add CSV parser for GIN"/"pinterest-integration-3.5" changes to "pinterest-integration-4.1.0-rc" pinterest#79
Author
|
Hi @ramtinb @henriqueng could you, please, review? |
Appply "[Feature] Add CSV parser for GIN"/"pinterest-integration-3.5" changes to "pinterest-integration-4.1.0-rc" pinterest#79
Appply "[Feature] Add CSV parser for GIN"/"pinterest-integration-3.5" changes to "pinterest-integration-4.1.0-rc" pinterest#79
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appply "[Feature] Add CSV parser for GIN"/"pinterest-integration-3.5" changes to "pinterest-integration-4.1.0-rc" #79
Why I'm doing:
We want to provide a list of pre-tokenized words that will be used by inverted index, allowing clients to use an external tokenizer to generate data that will be ingested by StarRocks. In some scenarios, we just can't add custom tokenizers into StarRocks due license issues and, therefore, we want to do tokenization in a stage before StarRocks.
Unfortunately Index Index does not support an array of strings, so a comma separated values format is necessary to forward the output of the external tokenizer. Existing tokenizers don't allow us to escape separators when necessary.
What I'm doing:
I am adding a CSV tokenizer that can be used as an intermediary format between external tokenizer and StarRocks. Essentially:
client generates tokens for a given string;
client sends these tokens as a string with comma separated values;
StarRocks ingest those comma separated values (tokens).
As any CSV, comma can be escaped when necessary, allowing client to have full control about the result tokens.
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: