Conversation
Contributor
Author
|
@pionxzh I attempted to make one of the features I requested a while back. Would you mind reviewing and pushing it if you think it's good whenever you have the time? 😊 |
Owner
|
Hi can you fix the lint error and dont commit package-lock.json? we use pnpm in this project. 🙏 |
Contributor
Author
|
Hi, I actually don't know how to "uncommit" |
Contributor
Author
|
How is it now? Still have a lint error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I attempted to make the page parser for GIF pages. I had help from AI, so it might not be perfect. Although, I have tested it, and it returned all the correct information after some tweaks.
I am not good at working with forks, so I have no idea why the entire
package-lock.jsonfile also was included in a commit, whoops. I guess just simply remove that 😅The page parser should return everything needed from the GIF page. Here is an example:
Hope this is helpful and usable :DDD