Composite revenue carrier (ADR 0014) + dashboard panel relocation - #15
Merged
Merged
Conversation
Introduces the composite carrier so a scenario can sum Cohort ARPU, Plan seats, Service monetization, and Credit pools simultaneously, with automatic double-counting prevention via PerspectiveRelation folding (cohort-plan upsell, copilot-ARPU folding, pool-service exclusive billing) and incommensurable-population detection. The wizard's "How does this initiative earn revenue?" step becomes a multi-select: choosing 2+ mechanisms auto-activates composite, and a dedicated composite toggle selects all three at once, replacing the old single-choice routing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Extracts the scenario configuration controls out of the scenario dashboard page into a dedicated ScenarioConfigurationPanel component and makes the diagnostics banner collapsible (grouped warning/note counts instead of one card per item), freeing vertical space for the central chart. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related but separable changes, kept as one PR with two commits since they touch overlapping dashboard files:
1. Composite revenue carrier (ADR 0014) + wizard multi-select (
edc0b0b)compositecarrier sums Cohort ARPU, Plan seats, Service monetization, and Credit pools in one scenario, with automatic double-counting prevention viaPerspectiveRelationfolding rules (cohort↔plan upsell, copilot↔ARPU folding, pool↔service exclusive billing) and incommensurable-population detection (>1.2x population mismatch).TriangulationPanelgets a Composite Component Breakdown table (additive/folded/pool-billed/blocked roles) and relation comparability warnings.2. Scenario Configuration Panel relocation (
568fecf)ScenarioConfigurationPanelcomponent, freeing vertical space for the central chart.DiagnosticsBannerbecomes collapsible (grouped warning/note counts) instead of one card per diagnostic item.Test plan
npm run check— 0 errors (75 pre-existing warnings, unrelated)npm test— 235/235 passing across 11 suites/scenarios/new:modelingType/revenueCarrierhidden fieldsrevenueCarrierand the pool-tierrequiredattributeScenarioConfigurationPaneldashboard layout (not re-verified in this session — carried over from an earlier session's work)🤖 Generated with Claude Code