Open
Conversation
Contributor
|
I would put this one into the workflows section - because it's not about an applied use case. It's more about steps or tools somebody might need to accomplish a task - which seems like a workflow. Kind of arbitrary, but it's the best categorization we could come up with |
matthew-ballard
requested changes
Mar 27, 2026
Contributor
matthew-ballard
left a comment
There was a problem hiding this comment.
Hey - thanks for publishing this! I have a few comments:
- "Open in Colab" won't work very well because you've added the
Hawaii.jsonfile in a folder, rather than inline. The way we set up Colab only uses the ipynb file itself. Options are to remove Colab link or put geojson into ipynb cell. - In the introduction, it would be good to give context for where this is relevant to, i.e. Processing and Statistical APIs.
- In the second "optional" imports section - it seems like these are required to complete the notebook. If they, I would add them to install the Docker workflow. Alternatively, use a pattern to show geospatial data from another notebook, such using just using geopandas. I would recommend this option to keep it simpler with fewer unnecessary packages. Also not sure if the imagery basemap is adding useful context. Could do something like this (and this would need to be applied to subsequent uses)
def show_area(area_shape):
# 1. Wrap the shape in a GeoSeries (a simple GeoPandas object)
# This automatically handles Polygons and MultiPolygons
gs = gpd.GeoSeries([area_shape])
# 2. Plot it directly
fig, ax = plt.subplots(figsize=(8, 8))
gs.plot(ax=ax, facecolor='red', edgecolor='black', alpha=0.6)
# Clean up the look
ax.set_title("Area of Interest")
ax.set_xlabel("Longitude")
ax.set_ylabel("Latitude")
plt.grid(True, linestyle='--', alpha=0.5)
plt.show()
show_area(hawaii_area)
- I recommend updating the year in the NDVI example to be more recent imagery to something more recent than 2022.
- For the NDVI evalscript, it might be nice to show a multi-temporal evalscript that removes the clouds by taking a median value, for example
- there are some line that have
ruffthat I think can be removed, e.g.# ruff: noqa: C901, unless this is being used some how? - It would be helpful to have a bit of an outline up at the top for each of the options that are being used (regular grid, OSM, etc.). It would make it easier to navigate the notebook.
Contributor
|
On Matt's points:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a notebook based on the large area utilities example and adapts it for the
planetlabs/notebooksrepo.What’s included
sentinelhub-pyexample for notebook-repo useContext
The intention is to use this notebook in the repo first and then link to it from
docs.planet.com.