Draft
Conversation
|
cddaaaa to
2d27729
Compare
916c50b to
91df8c6
Compare
|
22c4f09 to
b590145
Compare
b590145 to
c37fa8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors line graph to Typescript, from chart.js library to d3.js library. Depends on the new query backend. #6173
The rationale for switching the library:
This PR currently runs line graph side-by-side with the refactored version. The idea is to be able to compare the refactored one with the current one, to detect any small intentional and unintentional changes.
To run locally,
.env.dev(diff below), start dev serverhttp://localhost:8001/dummy.site/settings/visibilityand set it to be publicChanges
Fixes
Tests
Changelog
Documentation
Dark mode